Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悶 add a minimal version of mime guessing to serve_dir #461

Merged
merged 1 commit into from May 7, 2020
Merged

馃悶 add a minimal version of mime guessing to serve_dir #461

merged 1 commit into from May 7, 2020

Conversation

jbr
Copy link
Member

@jbr jbr commented Apr 23, 2020

this is probably just a stopgap, but resolves the issue wherein browsers download text files served with a generic binary stream content type

@yoshuawuyts yoshuawuyts mentioned this pull request Apr 25, 2020
Closed
@jbr jbr changed the title add a minimal version of mime guessing to serve_dir 馃悶 add a minimal version of mime guessing to serve_dir May 6, 2020
yoshuawuyts
yoshuawuyts approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yoshuawuyts yoshuawuyts merged commit b7252dd into http-rs:master May 7, 2020
@yoshuawuyts yoshuawuyts mentioned this pull request May 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbr @yoshuawuyts